Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categories searching error when uploading photos #5884

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zihanpan
Copy link
Contributor

@zihanpan zihanpan commented Oct 22, 2024

Description (required)

Fixes #5872

  1. Adjustments to error handling logic:
    Added the isInitialLoad status variable to track whether it was an initial load. This variable is set to true when the page starts loading and false for the first call to searchForCategories to ensure that no error messages are displayed during the initial loading.

  2. Null input processing:
    In the searchForCategories method, a check for whether the input is empty has been added. If the input is empty and the initial load is not categories_found, the call view.showError(R.String.no_categories_found) shows an error.

  3. EditText handling:
    Ensure that edittext continues to receive input after ErrorShow is triggered, and that categories cannot be retrieved due to conflicts

Tests performed (required)

Tested Debug on Medium Phone with API level 34.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this branch.

Unfortunately, at the categories step, the suggestions list was empty.
There should have been at least some suggestions based on history and location.
As soon as I started typing in the search field, all suggestions (based on history and location) appeared immediately.

Would you mind checking?
Thanks! :-)

@nicolas-raoul
Copy link
Member

screen-20241105-140315.mp4

@nicolas-raoul
Copy link
Member

Here suggestions do not disappear upon erasing the search:

screen-20241105-172927.mp4

@zihanpan
Copy link
Contributor Author

zihanpan commented Nov 6, 2024

I just tried this branch.

Unfortunately, at the categories step, the suggestions list was empty. There should have been at least some suggestions based on history and location. As soon as I started typing in the search field, all suggestions (based on history and location) appeared immediately.

Would you mind checking? Thanks! :-)

Thanks for bringing this to my attention! I’d be happy to check and investigate the issue further.

I'll take a look at why the suggestions list might not be appearing initially and see if there are any improvements we can make.

I’ll keep updating!

@nicolas-raoul
Copy link
Member

Did you get a chance to check? :-)

Another issue is that sometimes the previously selected category is pre-selected.

And it seems like selecting a depiction (such as cat) does not make the matching category (Cats) to be suggested in the categorization screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error shown in category search (upload photo) when no input is provided
3 participants