Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change the name of the rc_iris label? #115

Open
trexfeathers opened this issue Aug 12, 2024 · 4 comments
Open

Can we change the name of the rc_iris label? #115

trexfeathers opened this issue Aug 12, 2024 · 4 comments
Assignees
Labels

Comments

@trexfeathers
Copy link
Contributor

Comment:

The current guidance suggests iris_rc would be the correct name. This leaves us vulnerable to mistakes when following our release workflow.

If the cost of changing the name would be great, then I reckon don't bother. But if it would be easy then this would be helpful.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 12, 2024

Sure, you can change it by modifying it here: https://github.com/conda-forge/iris-feedstock/blob/rc/recipe/conda_build_config.yaml#L2

BTW, it too me a while to find the right branch! Why are there so many branches here?

https://github.com/conda-forge/iris-feedstock/branches/active

Note that PRs from direct from branches, instead of a branched fork, will result in premature package upaload!

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Aug 13, 2024

Sure, you can change it by modifying it here: https://github.com/conda-forge/iris-feedstock/blob/rc/recipe/conda_build_config.yaml#L2

@ocefpaf nice, thanks, I'll get on that soon.

Why are there so many branches here?

We would love your opinion on this, if you are interested. conda-forge occasionally makes automated improvements to feedstock repos (e.g. #96), but these are obviously applied to the main branch only. We are therefore concerned with the rc branch getting out-of-date as time goes on - we wanted a way to get the latest main updates onto rc.

  • ❌ Merging main into rc seemed inappropriate, since this might change one of the many files that are managed by conda-forge, and are not supposed to be touched directly by maintainers. In the worst case there might even be conflicts to resolve.
  • The conda-forge guidance allows for maintainers creating an rc branch from main, so we decided to do that 'fresh' for every new major/minor release.

Can you think of a better solution? Our current one does seem a little strange.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 13, 2024

Changes like #96 should be few and far between. Even more so for pure Python packages. With that said, there is no good guidance on that. I prefer to port the commit before the re-render to the maintainance branch, and re-render the feedstock myself.

@trexfeathers
Copy link
Contributor Author

Thanks for the info, something for us to think about I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants