Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers org #76

Merged
merged 10 commits into from
May 10, 2024
Merged

Containers org #76

merged 10 commits into from
May 10, 2024

Conversation

k9withabone
Copy link
Member

  • Added a code of conduct, a security policy, and contribution guidelines.
  • Updated links to repository to reflect the new location.
  • The podlet container image was moved to ghcr.io/containers/podlet.

Closes #71

Adapted from the Buildah/Podman code of conduct.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Adapted from the Buildah/Podman security policy.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
The repository is now at https://github.com/containers/podlet

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Adapted from the Buildah/Podman contribution guidelines.

Suggests the use of conventional commits and clarifies that the
`Signed-off-by` footer is required for a PR to be merged.

Moved and expanded upon the building and continuous integration sections
from the `README.md` file to the new `CONTRIBUTING.md` file.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
The docker.io/k9withabone/podlet and quay.io/k9withabone/podlet
container images will no longer be updated.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
The podlet container image is now located at ghcr.io/containers/podlet.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Adds labels to the podlet container image and annotations to the
multi-arch manifest as suggested by the GitHub packages documentation:
<https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images>.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
@k9withabone k9withabone added this to the v0.3.0 milestone May 8, 2024
@k9withabone k9withabone linked an issue May 8, 2024 that may be closed by this pull request
@k9withabone
Copy link
Member Author

@cdrage, could you review CODE-OF-CONDUCT.md, CONTRIBUTING.md, and SECURITY.md?

Containerfile Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking caps, otherwise LGTM

@cdrage
Copy link

cdrage commented May 8, 2024

@TomSweeneyRedHat is the best to ask and I've seen he has done a review!

Above all LGTM after his changes

@k9withabone
Copy link
Member Author

Just found out that the --annotation option on podman manifest create is new to Podman v5.0.0. Looks like I'll need to figure out how to run newer versions of Podman/Buildah (current version in the runner is Podman v4.6.2, from the Kubic project) or a different way to update the manifest for the release-container action.

@k9withabone
Copy link
Member Author

Thanks for the review @TomSweeneyRedHat! I'll work on fixing the capitalization throughout the documentation.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
@k9withabone k9withabone merged commit ffdbb03 into main May 10, 2024
10 checks passed
@k9withabone k9withabone deleted the containers-org branch May 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being added to the https://github.com/containers org
3 participants