feat: Do not query /jobs/triggers with a partialFilter #1571
Conversation
One might want to avoid querying the `/jobs/triggers` route and stick to the `/data` route, to avoid extra work from the stack, that can be costful. We were using the existence of `worker` and `type` keys in selector, but a partialFilter existence should also force the use of the `/data` route.
| @@ -122,7 +122,8 @@ class TriggerCollection extends DocumentCollection { | |||
| */ | |||
| async find(selector = {}, options = {}) { | |||
| const { worker, type, ...rest } = selector | |||
| const hasOnlyWorkerAndType = Object.keys(rest).length === 0 | |||
| const hasOnlyWorkerAndType = | |||
| Object.keys(rest).length === 0 && !options.partialFilter | |||
There was a problem hiding this comment.
nit: hasOnlyWorkerAndType is not accurate anymore
There was a problem hiding this comment.
Hmm I don't think so, hasOnlyWorkerAndType is true if there is no other keys than worker and type in selector and NO partialFilter.
Reversely, if there is another key or a partialFilter, hasOnlyWorkerAndType is false
There was a problem hiding this comment.
and NO partialFilter that part made me think that it is not accurate anymore.
Is it possible that there is no worker and type in selector but a partial filter is present ?
edit: oh they are linked together, so it can not happen ?
There was a problem hiding this comment.
Is it possible that there is no worker and type in selector but a partial filter is present ?
Yes it can. And in this case, hasOnlyWorkerAndType is false, as there is a partialFilter
One might want to avoid querying the
/jobs/triggersroute and stick to the/dataroute, to avoid extra work from the stack, that can be costful.We were using the existence of
workerandtypekeys in selector, but a partialFilter existence should also force the use of the/dataroute.