Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve watch script to output result #1576

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Dec 18, 2024

Since we updated Lerna to V8, the task-runner implementation has been changed from p-map/p-queue to nx

The side effect is that we now have a very light output when running yarn watch with no feedback when the build fails

To fix this, we can add the --stream argument in addition to the --parallel one in order to get the build logs back

The Lerna's --stream argument is equivalent to the Nx's --output-style=stream one

More info:

Since we updated Lerna to V8, the task-runner implementation has been
changed from `p-map/p-queue` to `nx`

The side effect is that we now have a very light output when running
`yarn watch` with no feedback when the build fails

To fix this, we can add the `--stream` argument in addition to the
`--parallel` one in order to get the build logs back

The Lerna's `--stream` argument is equivalent to the Nx's
`--output-style=stream` one

More info:
- https://github.com/lerna/lerna/releases/tag/v6.0.0
- https://nx.dev/nx-api/nx/documents/run-many#outputstyle
- https://fig.io/manual/lerna/run
@Ldoppea Ldoppea merged commit a670054 into master Dec 18, 2024
3 checks passed
@Ldoppea Ldoppea deleted the fix/watch_stream branch December 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants