fix: Links' onLogin should be awaited #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was adding an I/O for nothing, as we do nothing with the adapter name anymore.
The `onLogin` for a link is async, so it should be awaited to ensure that everything is initialized before we actually use the link
paultranvan
force-pushed
the
fix/links
branch
from
c8db4a5 to
8f001b6
Compare
Ldoppea
approved these changes
Jan 29, 2025
paultranvan
force-pushed
the
fix/links
branch
from
377741e to
61a5920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onLoginfor a link is async, so it should be awaited to ensurethat everything is initialized before we actually use the link