Use displayName in list's first column and don't sort contacts in list #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
changed the title
|
#662 merged, if nothing wrong this is a green light for merging this one |
Crash--
reviewed
Aug 20, 2020
src/components/ContactsList/__snapshots__/ContactsListDataLoader.spec.jsx.snap
Show resolved
Hide resolved
JF-Cozy
force-pushed
the
fix/list
branch
5 times, most recently
from
9bbda71 to
e9cabf4
Compare
Crash--
reviewed
Aug 24, 2020
y-lohse
reviewed
Aug 24, 2020
Crash--
reviewed
Aug 24, 2020
Crash--
approved these changes
Aug 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part [3] of multiple PR about the new sort logic in the application. Tests will maybe failed and probably don't after merging previous PR and rebasing this one.
displayNameof a contact to show contact's information in first columnContactIdentityto usegetInitials()andgetFullname()from cozy-clientContactListand change it to don't sort contacts (they will be sorted directly in the App and then past to the ContactList in an other PR)Must be merged after #662