feat: Handle offline mode in Flagship app #2186
Open
+637
−657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (7)
Unchanged files (6)
Total files change +7.94KB +0.25% Final result: ✅ View report in BundleMon website ➡️ |
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 19, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 19, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 19, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 23, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 23, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 24, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
This was referenced Sep 24, 2024
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 24, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
added a commit
to cozy/cozy-client
that referenced
this pull request
Sep 24, 2024
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: cozy/cozy-home#2186
Ldoppea
force-pushed
the
feat/offline
branch
from
3041534 to
797a312
Compare
In cozy/cozy-client#1460 we implemented a new `useSettings` hook This hook can be used in `DefaultRedirectionSnackbar` in order to simplify code and homogenize the way we access cozy-apps settings
We want cozy-home to be compatible with the new Flagship app's Offline mode When hosted in a Flagship app's WebView we now want to use FlagshipLink instead of StackLink in cozy-client This link will allow to redirect all queries to the Flagship app that will handle data access when offline but also when online Related PR: cozy/cozy-client#1507 Related PR: cozy/cozy-flagship-app#1239
paultranvan
reviewed
Jan 29, 2025
| @@ -13,6 +13,7 @@ | |||
| }, | |||
| "version": "1.85.0", | |||
| "licence": "AGPL-3.0", | |||
| "offline_support": true, | |||
There was a problem hiding this comment.
Is this documented somewhere? If not, we should do it
There was a problem hiding this comment.
The documentation is not merged yet, but you can preview it there: https://github.com/cozy/cozy-flagship-app/blob/28394cac703df96e00274cef6e985a8060046dd1/docs/how-to-make-cozy-app-offline-compatible.md
There was a problem hiding this comment.
Ok, we should also think to add it here: https://docs.cozy.io/en/cozy-apps-registry/#properties-meaning-reference
At startup we check some "app highlights" status, typicallky for backup or geolocation tracking. In the tracking case, we need to query the database in order to check if there is some geolocation data. This query might fail in offline if the local database is not ready. And this failure was causing an infinite loop, because a retry was made for each failed query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want cozy-home to be compatible with the new Flagship app's Offline mode
When hosted in a Flagship app's WebView we now want to use FlagshipLink instead of StackLink in cozy-client
This link will allow to redirect all queries to the Flagship app that will handle data access when offline but also when online
Related PR: cozy/cozy-client#1507
Related PR: cozy/cozy-flagship-app#1239
Related PR: cozy/cozy-libs#2562
Related PR: cozy/cozy-libs#2581
Related PR: cozy/cozy-libs#2585
TODO:
downloadFile()method from cozy-client cozy-libs#2581 is merged