fix: Disable fastRefresh in shared Rsbuild configuration
#2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
requested review from
JF-Cozy,
Merkur39,
zatteo and
doubleface
as code owners
In our projects, we found that using `rsbuild build --watch --mode development` instead of just `rsbuild build --watch` would speed up the re-build process But when doing so, the bundler enables the [fastRefresh](https://rsbuild.dev/plugins/list/plugin-react#fastrefresh) mode from plugin-react For now, this mode does not work and trying to run the cozy-apps would produce a blank screen with some `$RefreshSig$ is not defined`. This may be due to our configuration where the cozy-apps are served by the cozy-stack instead of the Rsbuild dev server Until we find how to make it work, we want to disable this feature by default It is still possible to enable it by setting the `enableFastRefresh` parameter to `true` when calling `getRsbuildConfig()`
Ldoppea
force-pushed
the
fix/rsbuild-config-dev
branch
from
8a6a839 to
3db3578
Compare
zatteo
approved these changes
Jan 14, 2025
|
Closing this in favor of #2700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects, we found that using
rsbuild build --watch --mode developmentinstead of justrsbuild build --watchwould speed up the re-build processBut when doing so, the bundler enables the
fastRefresh mode from plugin-react
For now, this mode does not work and trying to run the cozy-apps would produce a blank screen with some
$RefreshSig$ is not defined. This may be due to our configuration where the cozy-apps are served by the cozy-stack instead of the Rsbuild dev serverUntil we find how to make it work, we want to disable this feature by default
It is still possible to enable it by setting the
enableFastRefreshparameter totruewhen callinggetRsbuildConfig()