Skip to content

Commit

Permalink
Fix: abstract EventLoop::Polling#system_add invalid signature (#15380)
Browse files Browse the repository at this point in the history
The abstract method refers to the non existing `Index` type. Weirdly the compiler won't complain until someone defines an `Index` type.

Resolves #15357

(cherry picked from commit 5a245d9)

Co-authored-by: Johannes Müller <straightshoota@gmail.com>
  • Loading branch information
github-actions[bot] and straight-shoota authored Jan 28, 2025
1 parent cfd8ea1 commit ea98639
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/crystal/event_loop/polling.cr
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ abstract class Crystal::EventLoop::Polling < Crystal::EventLoop
private abstract def system_run(blocking : Bool, & : Fiber ->) : Nil

# Add *fd* to the polling system, setting *index* as user data.
protected abstract def system_add(fd : Int32, index : Index) : Nil
protected abstract def system_add(fd : Int32, index : Arena::Index) : Nil

# Remove *fd* from the polling system. Must raise a `RuntimeError` on error.
#
Expand Down

0 comments on commit ea98639

Please sign in to comment.