Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query runtime version of LLVM #15355

Merged

Conversation

straight-shoota
Copy link
Member

Use the runtime version of libllvm (via LLVMGetVersion, if available) for crystal --version and Crystal::LLVM_VERSION constant. The version of a dynamically loaded library might differ from LibLLVM::VERSION which is the version at build time.

Resolves #15353

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:cli labels Jan 18, 2025
@straight-shoota straight-shoota self-assigned this Jan 18, 2025
@straight-shoota straight-shoota changed the title Query runtime version of LLVM Fix query runtime version of LLVM Jan 18, 2025
@straight-shoota straight-shoota added this to the 1.16.0 milestone Jan 18, 2025
@straight-shoota straight-shoota merged commit 39aaae5 into crystal-lang:master Jan 20, 2025
70 checks passed
@straight-shoota straight-shoota deleted the fix/compiler-llvm-version branch January 20, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM version in compiler --version may be inaccurate
2 participants