fix: devDependencies property doesn't exist when assigning dependencies

Closes: #23
d4rkr00t · Mar 20, 2022 · a8d005c · a8d005c
1 parent 6aae2c7
commit a8d005c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 16 deletions.
diff --git a/.changeset/lovely-cougars-turn.md b/.changeset/lovely-cougars-turn.md
@@ -0,0 +1,5 @@
+---
+"@opaline/core": patch
+---
+
+devDependencies property doesn't exist when assigning dependencies
diff --git a/.changeset/slimy-files-rhyme.md b/.changeset/slimy-files-rhyme.md
@@ -0,0 +1,5 @@
+---
+"@opaline/core": patch
+---
+
+devDependencies property doesn't exist when assigning dependencies
diff --git a/packages/core/cli/commands/create.js b/packages/core/cli/commands/create.js
@@ -132,18 +132,17 @@ let updatePackageJson = {
       "@opaline/core": "*",
     };
 
+    pkgJson.devDependencies = {
+      "lint-staged": "*",
+      "pre-commit": "*",
+      prettier: "*",
+    };
+
     if (ctx.isTS) {
       pkgJson.scripts.typecheck = "tsc";
-
-      pkgJson.devDependencies = {
-        typescript: "*",
-      };
+      pkgJson.devDependencies["typescript"] = "*";
     }
 
-    pkgJson.devDependencies["lint-staged"] = "*";
-    pkgJson.devDependencies["pre-commit"] = "*";
-    pkgJson.devDependencies["prettier"] = "*";
-
     await writeFile(pkgJsonPath, JSON.stringify(pkgJson, null, 2), "utf8");
   },
 };

diff --git a/packages/core/commands/create.ts b/packages/core/commands/create.ts
@@ -123,18 +123,17 @@ let updatePackageJson: Task<TaskCtx, TaskParams> = {
       "@opaline/core": "*",
     };
 
+    pkgJson.devDependencies = {
+      "lint-staged": "*",
+      "pre-commit": "*",
+      prettier: "*",
+    };
+
     if (ctx.isTS) {
       pkgJson.scripts.typecheck = "tsc";
-
-      pkgJson.devDependencies = {
-        typescript: "*",
-      };
+      pkgJson.devDependencies["typescript"] = "*";
     }
 
-    pkgJson.devDependencies["lint-staged"] = "*";
-    pkgJson.devDependencies["pre-commit"] = "*";
-    pkgJson.devDependencies["prettier"] = "*";
-
     await writeFile(pkgJsonPath, JSON.stringify(pkgJson, null, 2), "utf8");
   },
 };