Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow extra environment variables for helm deployment #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chart/dapr-dashboard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ helm install dapr-dashboard dapr/dapr-dashboard
| `tolerations` | Pods will be allowed to schedule onto a node whose taints match the tolerations | `{}` |
| `labels` | Custom pod labels | `{}` |
| `k8sLabels` | Custom metadata labels | `{}` |
| `rbac.namespaced` | Removes cluster wide permissions where applicable | `false` |
| `rbac.namespaced` | Removes cluster wide permissions where applicable | `false` |
| `extraEnv` | Additional environment variables to pass to the dapr-dashboard container | `[]` |
3 changes: 3 additions & 0 deletions chart/dapr-dashboard/templates/dapr_dashboard_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
{{- with .Values.extraEnv }}
{{- toYaml . | nindent 8 }}
{{- end }}
ports:
- containerPort: 8080
resources:
Expand Down
2 changes: 2 additions & 0 deletions chart/dapr-dashboard/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@ k8sLabels:
app.kubernetes.io/version: "{{ .Values.image.tag }}"
app.kubernetes.io/part-of: "dapr"
app.kubernetes.io/managed-by: "helm"

extraEnv: []