fix(proto): update gRPC requests to use the correct request parameters #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 55.79% 55.79%
=======================================
Files 14 14
Lines 319 319
Branches 63 63
=======================================
Hits 178 178
Misses 124 124
Partials 17 17 ☔ View full report in Codecov by Sentry. |
shubham1172
changed the title
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
yaron2
approved these changes
Mar 6, 2024
shubham1172
added a commit
to shubham1172/js-sdk
that referenced
this pull request
Mar 6, 2024
dapr#581) * See if actions break Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update getMetadata and shutdown usage Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Revert temp change Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Remove a test Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> --------- Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
shubham1172
added a commit
that referenced
this pull request
Mar 6, 2024
* fix(proto): update gRPC requests to use the correct request parameters (#581) * See if actions break Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update getMetadata and shutdown usage Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Revert temp change Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Remove a test Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> --------- Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * chore(release): Prepare for v3.3.1 release (#582) Bump package version; Signed-off-by: Shubham Sharma <shubhash@microsoft.com> --------- Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some protos were updated in dapr/dapr@4d4c8b9, which were not changed in the SDK. Two problems,
(1) no compile time errors
(2) our e2e tests were ... not reporting failure! 🤦🏻
This PR:
(1) fixes the two specific requests that had changed in the proto -
getMetadataandshutdown(2) fixes the NPM script which was using
;instead of&&for e2e tests (https://unix.stackexchange.com/questions/187145/whats-the-difference-between-semicolon-and-double-ampersand)(3) removes a test introduced in #571, which won't work with Redis. It need Postgres/Azure app config.
Issue reference
Please reference the issue this PR will close: #580
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: