ENH: size() to return None on dask instead of nan #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
crusaderky
force-pushed
the
test_size
branch
3 times, most recently
from
af0a5db to
d9f5293
Compare
crusaderky
commented
Jan 8, 2025
| assert size(x) == 3 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("library", all_libraries) |
There was a problem hiding this comment.
This doesn't actually test ndonnx's None case until #232 gets merged.
|
CI failure seems unrelated |
ev-br
approved these changes
Jan 9, 2025
crusaderky
added a commit
to crusaderky/array-api-compat
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dask arrays of unknown shape return NaN in their
.sizeand.shapeproperties. This was chosen a long time before the Array API standard existed, but alas diverges from the array API standard itself:ndonnx, another library which can have arrays of unknown shape, uses None instead.
This PR changes the
size()function to make dask conform to the standard and adds units tests which were previously missing.Q: Should we add a
shape()function to cover for Dask's.shapeproperty non-standard behaviour?