ENH: is_lazy_array and is_writeable_array to return False on non-arrays #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
is_array_object
branch
from
b2e692e to
0c1b7dd
Compare
crusaderky
commented
Jan 17, 2025
| assert __name__.endswith('.common._helpers') | ||
| return __name__.removesuffix('.common._helpers') | ||
|
|
||
|
|
||
| def is_numpy_namespace(xp) -> bool: |
There was a problem hiding this comment.
Sphinx gave me grief over ModuleType, so I left it out of scope for this PR.
|
LGTM, thanks @crusaderky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
is_lazy_arrayandis_writeable_arrayto return False when the argument is not an array API object at all.This puts them in line with all other
is_*_arrayfunctions and is coherent withisinstancesemantics.Clarify in the documentation that all
is_*_arrayobjects accept any object as parameter.Out of scope: annotate with
TypeIs, which is very much non-trivial.