Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: numpy XPASS cleanup #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TST: numpy XPASS cleanup #247

wants to merge 1 commit into from
+3 −135

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky crusaderky closed this Jan 30, 2025
@crusaderky crusaderky reopened this Jan 30, 2025
@crusaderky crusaderky marked this pull request as ready for review January 31, 2025 09:25
@crusaderky crusaderky changed the title WIP numpy XPASS cleanup TST: numpy XPASS cleanup Jan 31, 2025
@crusaderky
Copy link
Contributor Author

@ev-br ready for review

@ev-br
Copy link
Contributor

ev-br commented Jan 31, 2025

Now that you touched numpy versions :-), there's something strange. Numpy-dev requires python >=3.11 (cf numpy/numpy@688669f), how come CI passes with numpy-dev and python==3.10 at https://github.com/data-apis/array-api-compat/actions/runs/13061139491/job/36444175360?pr=247

This should probably be cleaned up, too.

@crusaderky
Copy link
Contributor Author

@ev-br done. An admin needs to update the expected checks in the project settings.

@ev-br
Copy link
Contributor

ev-br commented Jan 31, 2025

An admin needs to update the expected checks in the project settings.

Thanks! That'd be @rgommers, I suspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @ev-br