Enable testifylint and fix the issues #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Replace require.NoError with assert.NoError in HTTP handlers
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
reviewed
Jan 2, 2025
| enable-all: true | ||
| disable: | ||
| # good check, but we have too many assert.(No)?Errorf? so excluding for now | ||
| - require-error |
There was a problem hiding this comment.
It tells you to use require.NoError(t, err) instead of assert.NoError(t, err). Presumably because otherwise you're reading bad values in the subsequent code.
pietern
approved these changes
Jan 2, 2025
|
Integration failures are unrelated (TestBundleInitOnMlopsStacks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There were 2 cases we --fix did the wrong thing - this seems to a be a bug in linter: Antonboom/testifylint#210
Nonetheless, I kept that check enabled, it seems useful, just need to be fixed manually after autofix.
Tests
Existing tests