Skip to content

Commit

Permalink
move-noisy-debug-logs-to-debug (#242)
Browse files Browse the repository at this point in the history
- these logs are the equivilent of "HERE" and account for ~75% of the logs but are generally
  not useful.  Moving them to debug
  • Loading branch information
tabmatfournier authored Apr 26, 2024
1 parent e3dee36 commit 690e62e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ protected void send(
events.stream()
.map(
event -> {
LOG.info("Sending event of type: {}", event.type().name());
LOG.debug("Sending event of type: {}", event.type().name());
byte[] data = Event.encode(event);
// key by producer ID to keep event order
return new ProducerRecord<>(controlTopic, producerId, data);
Expand Down Expand Up @@ -129,7 +129,7 @@ record -> {
if (event.groupId().equals(groupId)) {
LOG.debug("Received event of type: {}", event.type().name());
if (receiveFn.apply(new Envelope(event, record.partition(), record.offset()))) {
LOG.info("Handled event of type: {}", event.type().name());
LOG.debug("Handled event of type: {}", event.type().name());
}
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public CommitState(IcebergSinkConfig config) {
public void addResponse(Envelope envelope) {
commitBuffer.add(envelope);
if (!isCommitInProgress()) {
LOG.warn(
LOG.debug(
"Received commit response with commit-id={} when no commit in progress, this can happen during recovery",
((CommitResponsePayload) envelope.event().payload()).commitId());
}
Expand All @@ -57,7 +57,7 @@ public void addResponse(Envelope envelope) {
public void addReady(Envelope envelope) {
readyBuffer.add((CommitReadyPayload) envelope.event().payload());
if (!isCommitInProgress()) {
LOG.warn(
LOG.debug(
"Received commit ready for commit-id={} when no commit in progress, this can happen during recovery",
((CommitReadyPayload) envelope.event().payload()).commitId());
}
Expand Down Expand Up @@ -118,14 +118,14 @@ public boolean isCommitReady(int expectedPartitionCount) {
.sum();

if (receivedPartitionCount >= expectedPartitionCount) {
LOG.info(
LOG.debug(
"Commit {} ready, received responses for all {} partitions",
currentCommitId,
receivedPartitionCount);
return true;
}

LOG.info(
LOG.debug(
"Commit {} not ready, received responses for {} of {} partitions, waiting for more",
currentCommitId,
receivedPartitionCount,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void process() {
EventType.COMMIT_REQUEST,
new CommitRequestPayload(commitState.currentCommitId()));
send(event);
LOG.info("Started new commit with commit-id={}", commitState.currentCommitId().toString());
LOG.debug("Started new commit with commit-id={}", commitState.currentCommitId().toString());
}

consumeAvailable(POLL_DURATION, this::receive);
Expand Down

0 comments on commit 690e62e

Please sign in to comment.