-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the dependency libraries listed in pyproject.toml to extra #594
Conversation
82d7cfb
to
b3213b5
Compare
@@ -45,6 +43,7 @@ avro = [ | |||
|
|||
bigquery = [ | |||
"soda-core-bigquery>=3.3.1,<3.5.0", | |||
"google-cloud-bigquery>=3.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it was taking more than 30 minutes to resolve the dependency in CI, I limited the scope of google-cloud-bigquery in the same way as other packages.
...
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.
INFO: pip is looking at multiple versions of google-api-core to determine which version is compatible with other requirements. This could take a while.
INFO: pip is still looking at multiple versions of google-api-core to determine which version is compatible with other requirements. This could take a while.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.
Collecting google-cloud-bigquery<4.0,>=2.25.0 (from soda-core-bigquery<3.5.0,>=3.3.1->datacontract-cli==0.10.17)
Downloading google_cloud_bigquery-3.26.0-py2.py3-none-any.whl.metadata (8.7 kB)
Downloading google_cloud_bigquery-3.25.0-py2.py3-none-any.whl.metadata (8.9 kB)
Collecting google-cloud-core<3.0.0dev,>=1.6.0 (from google-cloud-bigquery<4.0,>=2.25.0->soda-core-bigquery<3.5.0,>=3.3.1->datacontract-cli==0.10.17)
Downloading google_cloud_core-2.4.0-py2.py3-none-any.whl.metadata (2.7 kB)
Downloading google_cloud_core-2.3.3-py2.py3-none-any.whl.metadata (2.5 kB)
Downloading google_cloud_core-2.3.2-py2.py3-none-any.whl.metadata (2.5 kB)
Downloading google_cloud_core-2.3.1-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.3.0-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.2.3-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.2.2-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.2.1-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.2.0-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.1.0-py2.py3-none-any.whl.metadata (2.4 kB)
Downloading google_cloud_core-2.0.0-py2.py3-none-any.whl.metadata (2.3 kB)
Downloading google_cloud_core-1.7.3-py2.py3-none-any.whl.metadata (2.4 kB)
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If necessary, I will make this a separate pull request, so please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break the dependency resolution on main for [all] extras.
I want to resolve this issue at #625, so I'm closing this pull request. |
resolves: #590