Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update design #528

Merged
merged 7 commits into from
Jan 31, 2025
Merged

feat: update design #528

merged 7 commits into from
Jan 31, 2025

Conversation

d-koppenhagen
Copy link
Member

No description provided.

@d-koppenhagen d-koppenhagen requested a review from Morl99 December 29, 2024 20:05
@d-koppenhagen
Copy link
Member Author

@Morl99 what do you think?

Copy link
Contributor

@Morl99 Morl99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it looks a lot cleaner and more professional than my original layout.

I do think, that the instructions and the file uploader now take a lot of real estate. On my resolution, that is more than half of the screen height. While some of that is attributed to whitespace (that we could reduce a bit in my opinion), maybe we could move the instructions to somewhere else. Or alternatively, change the design to be more dynamic and collapse once a file is selected (with the option to reopen).

What do you think?

@Morl99
Copy link
Contributor

Morl99 commented Jan 27, 2025

I like that it looks a lot cleaner and more professional than my original layout.

I do think, that the instructions and the file uploader now take a lot of real estate. On my resolution, that is more than half of the screen height. While some of that is attributed to whitespace (that we could reduce a bit in my opinion), maybe we could move the instructions to somewhere else. Or alternatively, change the design to be more dynamic and collapse once a file is selected (with the option to reopen).

What do you think?

Summarising our phone call:
We will try to use a vertical stepper component to collapse the header area once a file is successfully selected. There will be an option to go back and select a new file.

@d-koppenhagen
Copy link
Member Author

@Morl99 I adopted the design and updated screenshots. Please have a look :)

@d-koppenhagen
Copy link
Member Author

@Morl99 can you check the updated design?

Copy link
Contributor

@Morl99 Morl99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this turned out, thank you. The only thing I would change is commented in the code. Other than that, this is a great improvement :-)

src/pages/index.vue Outdated Show resolved Hide resolved
Co-authored-by: Carsten Hoffmann <carsten.c.hoffmann@deutschebahn.com>
@d-koppenhagen d-koppenhagen merged commit 9b019a3 into main Jan 31, 2025
1 check passed
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Morl99 Morl99 deleted the design branch January 31, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants