This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Fixed node compatibility #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, the old dependency is a fork of the original text-encoding-shim with a patch that fixed compatibility with node. The fork has been unmaintained for three years. Since then, the original has been updated, making the fork obsolete. Also, newer node versions have deprecated `GLOBAL` in favor of `global`. This breaks compatibility with the fork and causes demos.tf to crash on node v16.2.0. The original has been updated to fix this incompatibility, see commit https://gitlab.com/PseudoPsycho/text-encoding-shim/-/commit/142068f3a20b7038ab201fb49a4128198399b94f .
|
thanks |
|
Thanks for merging. Please push this to yarn/npm if possible. |
|
I need this fix for a project of mine. Is it possible to push this to yarn? |
|
done |
|
thanks a lot! |
|
It looks like the new version on yarn is missing the |
|
Output from |
|
it's been to long since I've published any js package, please try again I think I did it properly this time |
|
Thanks a lot for your time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the old dependency is a fork of the original text-encoding-shim with a patch that fixed compatibility with node.
The fork has been unmaintained for three years.
Since then, the original has been updated, making the fork obsolete.
Also, newer node versions have deprecated
GLOBALin favor ofglobal.This breaks compatibility with the fork and causes demos.tf to crash on node v16.2.0. The original has been updated to fix this incompatibility, see this commit.