This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Fix possibly-null type errors #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
reviewed
Mar 10, 2017
src/PacketHandler/PacketEntities.ts
Outdated
| @@ -94,7 +94,7 @@ function handleEntity(entity: PacketEntity, match: Match) { | |||
| } | |||
| } | |||
| if (prop.definition.ownerTableName === 'm_iAmmo') { | |||
| if (prop.value > 0) { | |||
| if (prop.value && prop.value > 0) { | |||
There was a problem hiding this comment.
The >0 shouldn't be needed since 0 is will evaluate to false
There was a problem hiding this comment.
Made it more specific. The type issue is that prop.value can be null there, so checking prop.value > 0 is throwing error TS2531: Object is possibly 'null'
icewind1991
approved these changes
Mar 10, 2017
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I do a fresh clone +
make, after thenpm installsucceeds, I get these type errors:This PR fixes those errors