ScriptOrigin changes

denoland · Dec 5, 2023 · bf45b61 · bf45b61
1 parent c29eb77
commit bf45b61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/binding.cc b/src/binding.cc
@@ -2367,13 +2367,13 @@ const v8::Value* v8__Script__Run(const v8::Script& script,
 }
 
 void v8__ScriptOrigin__CONSTRUCT(
-    v8::Isolate* isolate, uninit_t<v8::ScriptOrigin>* buf,
+    uninit_t<v8::ScriptOrigin>* buf,
     const v8::Value& resource_name, int resource_line_offset,
     int resource_column_offset, bool resource_is_shared_cross_origin,
     int script_id, const v8::Value& source_map_url, bool resource_is_opaque,
     bool is_wasm, bool is_module) {
   construct_in_place<v8::ScriptOrigin>(
-      buf, isolate, ptr_to_local(&resource_name), resource_line_offset,
+      buf, ptr_to_local(&resource_name), resource_line_offset,
       resource_column_offset, resource_is_shared_cross_origin, script_id,
       ptr_to_local(&source_map_url), resource_is_opaque, is_wasm, is_module);
 }

diff --git a/src/script.rs b/src/script.rs
@@ -31,7 +31,6 @@ extern "C" {
   ) -> *const Value;
 
   fn v8__ScriptOrigin__CONSTRUCT(
-    isolate: *mut Isolate,
     buf: *mut MaybeUninit<ScriptOrigin>,
     resource_name: *const Value,
     resource_line_offset: i32,
@@ -117,7 +116,6 @@ impl<'s> ScriptOrigin<'s> {
     unsafe {
       let mut buf = std::mem::MaybeUninit::<ScriptOrigin>::uninit();
       v8__ScriptOrigin__CONSTRUCT(
-        scope.get_isolate_ptr(),
         &mut buf,
         &*resource_name,
         resource_line_offset,