fix: forced tooltips below if they will overflow expected width #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scurker
requested changes
Feb 22, 2023
There was a problem hiding this comment.
I'm not sure this is the change that we actually want.
The auto-placement calculation comes from popper so I suspect there may be a bug in placement from that 3rd party library, but it should be trying to doing a best placement via the preventOverflow modifier. It might mean we need to upgrade the version if there is an existing bug that has been fixed, or raise an issue with popper but we need to do a little digging first to determine how we want to handle this.
|
Is this PR still relevant? |
Comment on lines
+187
to
+201
| if (elemRect) { | ||
| if (initialPlacement === 'right') { | ||
| const offset = bodyRect.right - elemRect.right; | ||
| if (offset < tooltipExpectedWidth && actualPlacement !== 'bottom') { | ||
| placement = 'bottom'; | ||
| setActualPlacement('bottom'); | ||
| } | ||
| } else if (initialPlacement === 'left') { | ||
| const offset = elemRect.left; | ||
| if (offset < tooltipExpectedWidth && actualPlacement !== 'bottom') { | ||
| placement = 'bottom'; | ||
| setActualPlacement('bottom'); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
A fun exercise: how would you write this code now over a year later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #905
A couple of discussion points for this would be to determine if we can calculate a minimum expected width and if we want to allow the user to define the minimum expected width.