Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan/CRO-858/fix incorrect loggedin status and residence country in growthbook #18037

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shayan-deriv
Copy link
Contributor

Changes:

  • Upgraded @deriv-com/analytics to the latest version.
  • Added growthbook.setAttribute() call to the logout action inside client-store.
  • Extracted the logic for generating GrowthBook config data into a reusable function.
  • Replaced Cookies.getJSON (deprecated) with Cookies.get and updated the related code accordingly.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ❌ Failed (Inspect) Feb 6, 2025 3:14am

@shayan-deriv shayan-deriv changed the title Shayan/cro 858/fix incorrect logged in status and residence country in growthbook Shayan/CRO-858/fix incorrect logged in status and residence country in growthbook Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Generating Lighthouse report...

Copy link
Contributor

github-actions bot commented Jan 31, 2025

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18037](https://github.com/deriv-com/deriv-app/pull/18037)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shayan-deriv-shayan-cro-858fix-incorr-ab7c64.binary.sx?qa_server=red.derivws.com&app_id=38777
    - **Original**: https://deriv-app-git-fork-shayan-deriv-shayan-cro-858fix-incorr-ab7c64.binary.sx
- **App ID**: `38777`

@shayan-deriv shayan-deriv changed the title Shayan/CRO-858/fix incorrect logged in status and residence country in growthbook Shayan/CRO-858/fix incorrect loggedin status and residence country in growthbook Jan 31, 2025
…cro-858/fix-incorrect-logged-in-status-and-residence-country-in-growthbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants