Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[universal] - Issue universal config change for non-root default codespace user and installing google chrome browser reuse sandboc to run puppeteer cli in universal image #1287

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[universal] - Issue universal config change for non-root default codespace user and installing google chrome browser reuse sandboc to run puppeteer cli in universal image #1287

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8dd6829
Changing config to force 1001 as UID for codespace in universal image
Kaniska244 Jan 22, 2025
1cb542b
Forcing the UID as 1001 for codespace user in universal image
Kaniska244 Jan 22, 2025
55086d0
Fixing puppeteer code on the --no-sandbox option to to make it work i…
Kaniska244 Jan 23, 2025
d8db581
Trying with different image version for runner.
Kaniska244 Jan 23, 2025
5ff7666
Reverting back the ubuntu version change for runer
Kaniska244 Jan 23, 2025
bdd690b
Setting updateRemoteUserUID flag to false.
Kaniska244 Jan 27, 2025
bd1149f
Reverting back the puppeteer fix to ensure the issue is isolated.
Kaniska244 Jan 27, 2025
f13430c
Another fix for puppeteer cli.
Kaniska244 Jan 28, 2025
8aa5786
Merge branch 'main' into Issue_Universal_Config_change_codespace_user
Kaniska244 Jan 29, 2025
af2f6b5
Changes done to make google chrome installation a part of the univers…
Kaniska244 Jan 29, 2025
0dd9b52
Commit again
Kaniska244 Jan 29, 2025
c2e8b2c
Small change to ensure postCreateCoammend doesn't fail when /workspac…
Kaniska244 Feb 2, 2025
cede6c1
Merge branch 'main' into Issue_Universal_Config_change_codespace_user
Kaniska244 Feb 4, 2025
bcccb04
Making change to change the UID workaround.
Kaniska244 Feb 5, 2025
be29d05
Check the increased image size.
Kaniska244 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/universal/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
],
"remoteUser": "codespace",
"containerUser": "codespace",

"updateRemoteUserUID": false,
"postStartCommand": "sudo chown -R 1000:1000 /workspaces/images/",
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

Expand Down
5 changes: 4 additions & 1 deletion src/universal/test-project/puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ const { exit } = require('process');
puppeteer.defaultArgs({
"args": ["--no-sandbox"]
})
const browser = await puppeteer.launch();
//const browser = await puppeteer.launch();
const browser = await puppeteer.launch({
args: ['--no-sandbox', '--disable-setuid-sandbox'],
});
const page = await browser.newPage();
await page.goto('https://example.com');
await page.screenshot({path: 'example.png'});
Expand Down
Loading