refactor: use highest mempool.space fee estimation

diamondhands-dev · Jul 22, 2023 · 7c38088 · 7c38088
1 parent fbd6403
commit 7c38088
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/lib/chain/MempoolSpace.ts b/lib/chain/MempoolSpace.ts
@@ -101,14 +101,16 @@ class MempoolSpace {
   };
 
   public latestFee = (): number | undefined => {
-    for (const api of this.apis) {
-      if (api.latestFee !== undefined) {
-        return api.latestFee;
-      }
+    const fees = this.apis
+      .map((c) => c.latestFee)
+      .filter((val): val is number => val !== undefined);
+
+    if (fees.length === 0) {
+      this.logger.warn(`All ${this.symbol} MempoolSpace endpoints failed`);
+      return undefined;
     }
 
-    this.logger.warn(`All ${this.symbol} MempoolSpace endpoints failed`);
-    return undefined;
+    return Math.max(...fees);
   };
 
   public stop = () => {

diff --git a/test/integration/chain/MempoolSpace.spec.ts b/test/integration/chain/MempoolSpace.spec.ts
@@ -27,13 +27,13 @@ describe('MempoolSpace', () => {
     expect(mempool.latestFee()).not.toBeUndefined();
   });
 
-  test('should pick results in order', async () => {
+  test('should pick highest returned fee', async () => {
     mempool.stop();
 
     const expectedFee = 42;
 
-    mempool['apis'][0]['latestFee'] = expectedFee;
-    mempool['apis'][1]['latestFee'] = expectedFee - 12;
+    mempool['apis'][0]['latestFee'] = expectedFee - 12;
+    mempool['apis'][1]['latestFee'] = expectedFee;
     expect(mempool.latestFee()).toEqual(expectedFee);
 
     mempool['apis'][0]['latestFee'] = undefined;