#163 [SL] - Hide command prompt on Windows.

exec/exec_posix.go

@@ -0,0 +1,9 @@
+//go:build !windows
+
+package exec
+
+import (
+	"os/exec"
+)
+
+func HideCommandWindow(cmd *exec.Cmd) {}

exec/exec_windows.go

@@ -0,0 +1,10 @@
+package exec
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+func HideCommandWindow(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
+}

tor/binary.go

@@ -11,6 +11,8 @@ import (
 	log "github.com/sirupsen/logrus"
 
 	"github.com/digitalautonomy/wahay/config"
+
+	execUtils "github.com/digitalautonomy/wahay/exec"
 )
 
 const libTorsocks = "libtorsocks.so"
@@ -368,6 +370,7 @@ func (b *binary) start(configFile string) (*runningTor, error) {
 	// no user input to these
 	/* #nosec G204 */
 	cmd := exec.CommandContext(ctx, b.path, "-f", configFile)
+	execUtils.HideCommandWindow(cmd)
 
 	if b.isBundle && len(b.env) > 0 {
 		log.Debugf("Tor is bundled with environment variables: %s", b.env)

tor/facades.go

@@ -13,6 +13,7 @@ import (
 	"strconv"
 
 	"github.com/digitalautonomy/wahay/config"
+	execUtils "github.com/digitalautonomy/wahay/exec"
 	"github.com/wybiral/torgo"
 	"golang.org/x/net/proxy"
 )
@@ -138,6 +139,7 @@ func (*realExecImplementation) ExecWithModify(bin string, args []string, cm Modi
 	// This executes the tor command, which is under control of the code
 	/* #nosec G204 */
 	cmd := exec.Command(bin, args...)
+	execUtils.HideCommandWindow(cmd)
 
 	if cm != nil {
 		cm(cmd)

tor/proxychains_windows.go

@@ -5,6 +5,7 @@ import (
 	"os/exec"
 
 	"github.com/digitalautonomy/wahay/config"
+	execUtils "github.com/digitalautonomy/wahay/exec"
 	log "github.com/sirupsen/logrus"
 )
 
@@ -35,6 +36,7 @@ func (i *instance) exec(mumbleBinary string, args []string, pre ModifyCommand) (
 	// This executes the proxychains command, and the args which are both under control of the code
 	/* #nosec G204 */
 	cmd := exec.CommandContext(ctx, mainArg, args...)
+	execUtils.HideCommandWindow(cmd)
 
 	if pre != nil {
 		pre(cmd)