#188 [LS] - Handle tor config path error properly.

digitalautonomy · Jan 20, 2025 · 683c670 · 683c670
1 parent 0b71fac
commit 683c670
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/tor/search_binary_posix.go b/tor/search_binary_posix.go
@@ -10,10 +10,7 @@ func isThereConfiguredTorBinary(path string) (b *binary, err error) {
 	}
 
 	if !filesystemf.IsADirectory(path) {
-		// We ommit the error here because it's ok while
-		// we are checking multiple possible paths where
-		// the Tor binary can be
-		b, _ = getBinaryForPath(path)
+		b, err = getBinaryForPath(path)
 		return
 	}
 

diff --git a/tor/search_binary_windows.go b/tor/search_binary_windows.go
@@ -67,16 +67,13 @@ func isThereConfiguredTorBinary(path string) (b *binary, err error) {
 	}
 
 	if !filesystemf.IsADirectory(path) {
-		// We ommit the error here because it's ok while
-		// we are checking multiple possible paths where
-		// the Tor binary can be
-		b, _ = getBinaryForPath(path)
+		b, err = getBinaryForPath(path)
 		return
 	}
 
 	torExecutablePath, _ := findTorExecutable(path)
 
-	b, _ = getBinaryForPath(torExecutablePath)
+	b, err = getBinaryForPath(torExecutablePath)
 	return
 }