-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use field.getUnlessDefault instead of field.get in UrlFormDataEncoder #1323
Conversation
|
1 similar comment
|
@Baccata could you help me figure out where to add unit tests for this change? It's unclear to me where they belong—maybe there aren't any unit tests for |
The unit tests of the core module live in the bootstrapped module, which makes it easier to write assertions against the generated code |
modules/core/src/smithy4s/http/internals/UrlFormDataEncoderSchemaVisitor.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a CHANGELOG entry for 0.18.5. Other than that, looks good to me
Fixes #1321.
PR Checklist (not all items are relevant to all PRs)