Add service transformation utils #1644
Merged
+100
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Feb 5, 2025
| @@ -96,3 +98,55 @@ final case class OperationSchema[I, E, O, SI, SO] private[smithy4s] ( | |||
| copy(streamedOutput = streamedOutput.map(f)) | |||
|
|
|||
| } | |||
|
|
|||
| object OperationSchema { | |||
There was a problem hiding this comment.
thought: if these are deemed overkill, I'm ok with removing them.
There was a problem hiding this comment.
the rest are more high-value though, I'd keep them as-is
There was a problem hiding this comment.
Couldn't these be methods on the OperationSchema class instead of static functions ?
There was a problem hiding this comment.
no, if we want them as polyfunctions (and we do, if we want nice things like what you see in the new test), they have to be outside of the class
Baccata
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)