issues #116 - log rotation with logrotate.d

daphne/access.py

@@ -68,3 +68,7 @@ def write_entry(
                 length or "-",
             )
         )
+
+    def close_stream(self):
+        self.stream.flush()
+        self.stream.close()

daphne/cli.py

@@ -1,6 +1,7 @@
 import argparse
 import functools
 import logging
+import signal
 import sys
 from argparse import ArgumentError, Namespace
 
@@ -40,6 +41,8 @@ class CommandLineInterface(object):
     server_class = Server
 
     def __init__(self):
+        self.access_log = None
+
         self.parser = argparse.ArgumentParser(description=self.description)
         self.parser.add_argument(
             "-p", "--port", type=int, help="Port number to listen on", default=None
@@ -183,6 +186,12 @@ def __init__(self):
 
         self.server = None
 
+    # For logrotate at SIGNALUSR1
+    def logrotate(self, signum, stack):
+        if self.access_log is not None:
+            access_log_stream = open(self.access_log, "a", 1)
+            self.server.rotate_log_action(AccessLogGenerator(access_log_stream))
+
     @classmethod
     def entrypoint(cls):
         """
@@ -244,7 +253,9 @@ def run(self, args):
             if args.access_log == "-":
                 access_log_stream = sys.stdout
             else:
+                self.access_log = args.access_log
                 access_log_stream = open(args.access_log, "a", 1)
+                signal.signal(signal.SIGUSR1, self.logrotate)
         elif args.verbosity >= 1:
             access_log_stream = sys.stdout
         # Import application

daphne/server.py

@@ -326,3 +326,7 @@ def log_action(self, protocol, action, details):
         """
         if self.action_logger:
             self.action_logger(protocol, action, details)
+
+    def rotate_log_action(self, log):
+        self.action_logger.close_stream()
+        self.action_logger = log