Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #35

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Documentation #35

merged 2 commits into from
Jan 4, 2025

Conversation

dmadison
Copy link
Owner

@dmadison dmadison commented Jan 4, 2025

Added doxygen comments to everything, in case anyone finds them useful.

Also moved two protected variables to private, where they should have been (ddd9e68). This is technically but not practically a breaking change, since these both have public getter/setter functions. This also prevents derived classes from setting the filtering range outside the validator's range, which would lead to unexpected remapping behavior.

These shouldn't be exposed, the public functions act as complete getter/setters.
@dmadison dmadison merged commit f20b689 into master Jan 4, 2025
6 checks passed
@dmadison dmadison deleted the docs branch January 4, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant