Allow filtering by resource state and health status, and update the filters based on visible grid items

[adamint]

Description

Currently, you can filter resources by type, but it would also be useful to filter by health status or by resource state. I extracted the resource filter UI into its own component ResourceFilters and converted SelectResourceTypes into a component that was more generic and so could be reused for state and health status (SelectResourceOptions). This also meant other refactoring was necessary, such as creating reusable methods Get/SetFieldVisibility from the getter and setter logic previously in AreAllTypesVisible.

Fixes #1190

In a follow-up, we could persist these values in the URL (#3647)

(note that, for example, finished and no state have disappeared from available options because no resource with those values is in the grid anymore)

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No (largely just a refactor)
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

Microsoft Reviewers: Open in CodeFlow

[JamesNK]

What happens if there are a lot of states, resources types and health states? The popup should probably have a maximum height and a scoll bar to handle that situation nicely.

[JamesNK]

Couple of examples of bugs.

Database type isn't in list because its resource is nested. Expanding the parent makes it display:

Problems with unselecting resource types:

These are both caused by filtering available options based on visible resources.

[adamint]

Couple of examples of bugs.

Database type isn't in list because its resource is nested. Expanding the parent makes it display:

Problems with unselecting resource types:

These are both caused by filtering available options based on visible resources.

Reverted the change.

[adamint]

What happens if there are a lot of states, resources types and health states? The popup should probably have a maximum height and a scoll bar to handle that situation nicely.

Added a max height and scroll bar.

[adamint]

@JamesNK

[JamesNK]

I think you should add some component tests to test these changes. We don't tests for resources page yet so you'll need to add some setup code for registering required services and JS calls, but there a lot of other pages already setup that you can follow.

[dotnet-policy-service]

This submission has been automatically marked as stale because it has been marked as requiring author action but has not had any activity for 14 days.
It will be closed if no further activity occurs within 7 days of this comment.

[JamesNK]

Do you intend to write component tests for this?