Update Path.GetDirectoryName Snippet3 #10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current docs are outdated to NRT and confuse quotes 1. variable should be type string? not string 2. uses old-style format string (new would use interpolated syntax) 3. filepath reassignment should use conditional syntax 4. results suggest using single-quote [i.e. char not string], ugh 5. the final returned result is null but demo output shows '' which is factually visually correct but confusingly indistinuishable from "" emptystring I propose replacement C# code for this Snippet3
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io |
|
Learn Build status updates of commit 1bc1f95: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
BillWagner
approved these changes
Jan 21, 2025
now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the current docs are outdated to NRT and confuse quotes
Describe your changes here.
I propose this replacement C# code to improve this Snippet3 accuracy and clarity