support compress request body #403
Conversation
zuisong
force-pushed
the
compress-request-body
branch
from
d7f708a to
f85194a
Compare
src/main.rs
Outdated
| if args.compress >= 1 && request.headers().get(CONTENT_ENCODING).is_none() { | ||
| let mut compressed = false; | ||
| if let Some(body) = request.body_mut() { | ||
| if let Ok(body_bytes) = body.buffer() { |
There was a problem hiding this comment.
Using buffer() might consume a lot of memory for extremely large files
There was a problem hiding this comment.
The into_reader() method of reqwest#Body is pub(crate). We cannot access it. Currently, it is not possible to achieve our goal.
There was a problem hiding this comment.
We'd have to wrap the file after opening it and before turning it into a Body. Currently we open the file here:
Line 444 in f75d092
But it's also OK to leave this out for now.
There was a problem hiding this comment.
@zuisong Can you add a TODO comment about compressing the file body without buffering it?
There was a problem hiding this comment.
Happy Chinese New Year! 🥳🥳🥳
I'm currently on vacation, but I will update the code as soon as possible regarding your comments later.
There was a problem hiding this comment.
No rush at all. Enjoy your vacation!
zuisong
force-pushed
the
compress-request-body
branch
from
e64e14f to
1ec0267
Compare
| @@ -779,6 +780,43 @@ fn successful_digest_auth() { | |||
| .stdout(contains("HTTP/1.1 200 OK")); | |||
| } | |||
|
|
|||
| #[cfg(feature = "online-tests")] | |||
There was a problem hiding this comment.
Can you move the tests into a separate file under tests/cases?
| /// The Content-Encoding header is set to deflate. | ||
| /// | ||
| /// Compression is skipped if it appears that compression ratio is negative. | ||
| /// Compression can be forced by repeating this option. |
There was a problem hiding this comment.
Should we also mention that compression cannot be forced if the Content-Encoding request header is present?
| get_command() | ||
| .arg(format!("{}/deflate", server.base_url())) | ||
| .args([ | ||
| &format!("key={}", "1".repeat(1000)), | ||
| "-x", | ||
| "-x", | ||
| "-f", | ||
| "--pretty=none", | ||
| ]) | ||
| .assert() | ||
| .stdout(indoc::formatdoc! {r#" | ||
| HTTP/1.1 200 OK | ||
| Date: N/A | ||
| Content-Type: text/plain | ||
| Content-Length: 1004 | ||
|
|
||
| key={c} | ||
| "#, c = "1".repeat(1000),}); | ||
|
|
||
| get_command() | ||
| .arg(format!("{}/deflate", server.base_url())) | ||
| .args([ | ||
| &format!("key={}", "1".repeat(1000)), | ||
| "-x", | ||
| "-x", | ||
| "-f", | ||
| "--pretty=none", | ||
| ]) | ||
| .assert() | ||
| .stdout(indoc::formatdoc! {r#" | ||
| HTTP/1.1 200 OK | ||
| Date: N/A | ||
| Content-Type: text/plain | ||
| Content-Length: 1004 | ||
|
|
||
| key={c} | ||
| "#, c = "1".repeat(1000),}); |
There was a problem hiding this comment.
Is the duplicate command invocation necessary here?
| } | ||
|
|
||
| #[test] | ||
| fn compress_request_body() { |
There was a problem hiding this comment.
Would it be possible to break this into multiple test cases?
implements https://httpie.io/docs/cli/compressed-request-body