Skip to content

Commit

Permalink
fix input
Browse files Browse the repository at this point in the history
  • Loading branch information
yanjiaxin534 committed Jan 21, 2025
1 parent 5372dac commit fb0d691
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions api/pkg/apis/v1alpha1/managers/solution/solution-manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func (s *SolutionManager) handleAllPlanCompletetion(ctx context.Context, planSta
if planState.Deployment.IsDryRun {
planState.Summary.SuccessCount = 0
}
if err := s.concludeSummary(ctx, planState.Deployment.Instance.ObjectMeta.Name, planState.Deployment.Generation, planState.Deployment.Hash, planState.Summary, planState.Namespace); err != nil {
if err := s.concludeSummary(ctx, planState.Deployment.Instance.ObjectMeta.Name, planState.Deployment.Generation, planState.Deployment.Hash, *planState.Summary, planState.Namespace); err != nil {
return err
}
log.InfoCtx(ctx, "final unlock %s", planState.Deployment.Instance.ObjectMeta.Name)
Expand Down Expand Up @@ -714,6 +714,10 @@ func (s *SolutionManager) saveStepResult(ctx context.Context, planState *PlanSta
// Log the update of plan state with the step result
log.InfoCtx(ctx, "V(Solution): Update plan state %v with step result %v phase %s", planState, stepResult, planState.Phase)
log.InfoCtx(ctx, "get TargetResults %+v", planState.Summary.TargetResults)
if planState.Summary.TargetResults == nil {
planState.Summary.TargetResults = make(map[string]model.TargetResultSpec)
log.InfoCtx(ctx, "init target results %+v", planState.Summary.TargetResults)
}
planState.CompletedSteps++
lockName := api_utils.GenerateKeyLockName(planState.Namespace, planState.Deployment.Instance.ObjectMeta.Name)
s.KeyLockProvider.TryLock(lockName)
Expand Down Expand Up @@ -1346,7 +1350,7 @@ func (s *SolutionManager) GetTargetStateForStep(target string, deployment model.
return targetSpec
}
func (s *SolutionManager) saveSummaryInfo(ctx context.Context, planState *PlanState, state model.SummaryState) error {
return s.saveSummary(ctx, planState.Deployment.Instance.ObjectMeta.Name, planState.Deployment.Generation, planState.Deployment.Hash, planState.Summary, state, planState.Namespace)
return s.saveSummary(ctx, planState.Deployment.Instance.ObjectMeta.Name, planState.Deployment.Generation, planState.Deployment.Hash, *planState.Summary, state, planState.Namespace)
}

func (s *SolutionManager) saveSummary(ctx context.Context, objectName string, generation string, hash string, summary model.SummarySpec, state model.SummaryState, namespace string) error {
Expand Down

0 comments on commit fb0d691

Please sign in to comment.