add summary cleanup manager to delete deprecated summaries periodically #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I am ok with this change, but this pr needs to wait for summary guid change - #588
| @@ -162,8 +175,8 @@ func (s *SummaryManager) ListSummary(ctx context.Context, namespace string) ([]m | |||
| return summaries, nil | |||
| } | |||
|
|
|||
| func (s *SummaryManager) UpsertSummary(ctx context.Context, summaryId string, generation string, hash string, summary model.SummarySpec, state model.SummaryState, namespace string) error { | |||
| oldSummary, err := s.GetSummary(ctx, summaryId, namespace) | |||
| func (s *SummaryManager) UpsertSummary(ctx context.Context, summaryId string, generation string, hash string, summary model.SummarySpec, state model.SummaryState, namespace string, softDelete bool) error { | |||
There was a problem hiding this comment.
Why we add softDelete option in upsert summary, not delete summary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#562
Add a summary cleanup manager as background job to delete deprecated summaries.