Addition of layout port check - checks pin position, shape, and label. #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a port check that verifies that all ports (pins and corresponding labels) in the golden user wrapper layout are present at the same positions in the user wrapper layout. The actual datatype -
pin
orlabel
- is irrelevant; only the layer names are considered. Box shapes are pins and text are labels. Pins and labels in the user layout but not the golden layout are ignored; this allows internal user ports. Extra user ports in the interface area will be flagged in the XOR check.This check is run after the XOR check.
Tested on
The golden
user_project_wrapper_empty.gds
file incaravel
has the internal power grid as pins. These are not required on the user project, souser_project_wrapper_empty.gds
file should also be updated in thempw_precheck
docker container. See this PR.Note that the golden layout is pulled from
mpw_precheck/_default_content/gds
forgf180mcu
pdks and typemini
but fromcaravel/gds
for all others. Maybe this should be standardized. @jeffdi @DavidRLindleyThe
caravel
directory used inmpw_precheck
is currently part of the docker container that will need to be rebuilt.The following error conditions were also tested independently (not as part of
mpw_precheck
).Sample errors while reading layout
Sample errors when comparing layouts