Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip mysql2@2.2.3 in TAV tests to workaround npm v6 install issue with github deps #2696

Merged
merged 1 commit into from
May 16, 2022
Merged

test: skip mysql2@2.2.3 in TAV tests to workaround npm v6 install issue with github deps #2696

merged 1 commit into from
May 16, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented May 16, 2022

mysql2@2.2.3 (and only that version) has a github dep:
"@types/mysql": "types/mysql",
Attempting to install that version with npm v6 (the npm in node v10, v12, and
v14) hits npm/cli#4896 which results in an
install so slow that is hits the default 2 minute 'npm install' timeout
in the tav tool.

This is the same root cause of elastic/apm-integration-testing#1483

@trentm
test: skip mysql2@2.2.3 in TAV tests to workaround npm v6 install iss…
0b0fc4f 
…ue with github deps

mysql2@2.2.3 (and only that version) has a github dep:
    "@types/mysql": "types/mysql",
Attempting to install that version with npm v6 (the npm in node v10, v12, and
v14) hits npm/cli#4896 which results in an
install so slow that is hits the default 2 minute 'npm install' timeout
in the `tav` tool.
@trentm trentm requested a review from astorm May 16, 2022 19:30
@trentm trentm self-assigned this May 16, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 16, 2022
@trentm
Copy link
Member Author

trentm commented May 16, 2022

This fixes the recent TAV test run failures on main:
https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/main/166/

[2022-05-16T06:43:15.649Z] node_tests_1  | -- installing ["mysql2@2.2.4"]
[2022-05-16T06:43:24.377Z] node_tests_1  | -- running test "node test/instrumentation/modules/mysql2/mysql.test.js" with mysql2
[2022-05-16T06:43:25.985Z] node_tests_1  | -- running test "node test/instrumentation/modules/mysql2/pool-release-1.test.js" with mysql2
[2022-05-16T06:43:26.587Z] node_tests_1  | -- required packages ["mysql2@2.2.3"]
[2022-05-16T06:43:26.587Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:45:26.563Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (2/10)...
[2022-05-16T06:45:26.564Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:47:26.641Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (3/10)...
[2022-05-16T06:47:26.641Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:49:26.720Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (4/10)...
[2022-05-16T06:49:26.720Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:51:26.787Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:51:26.787Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (5/10)...
[2022-05-16T06:53:26.820Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:53:26.820Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (6/10)...
[2022-05-16T06:55:26.952Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:55:26.953Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (7/10)...
[2022-05-16T06:57:26.986Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (8/10)...
[2022-05-16T06:57:26.986Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T06:59:27.022Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (9/10)...
[2022-05-16T06:59:27.022Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T07:01:27.161Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] (npm install took too long) - retrying (10/10)...
[2022-05-16T07:01:27.161Z] node_tests_1  | -- installing ["mysql2@2.2.3"]
[2022-05-16T07:03:27.103Z] node_tests_1  | -- error installing ["mysql2@2.2.3"] - aborting!
[2022-05-16T07:03:27.103Z] node_tests_1  | Error: npm install took too long
[2022-05-16T07:03:27.103Z] node_tests_1  |     at Timeout.<anonymous> (/app/node_modules/test-all-versions/index.js:305:10)
[2022-05-16T07:03:27.103Z] node_tests_1  |     at ontimeout (timers.js:436:11)
[2022-05-16T07:03:27.103Z] node_tests_1  |     at tryOnTimeout (timers.js:300:5)
[2022-05-16T07:03:27.103Z] node_tests_1  |     at listOnTimeout (timers.js:263:5)
[2022-05-16T07:03:27.103Z] node_tests_1  |     at Timer.processTimers (timers.js:223:10)
[2022-05-16T07:03:27.103Z] node_tests_1  | -- fatal: undefined
[2022-05-16T07:03:27.103Z] node_tests_1  | npm ERR! code ELIFECYCLE
[2022-05-16T07:03:27.104Z] node_tests_1  | npm ERR! errno 1
[2022-05-16T07:03:27.104Z] node_tests_1  | npm ERR! elastic-apm-node@3.33.0 test:tav: `tav --quiet`
[2022-05-16T07:03:27.104Z] node_tests_1  | npm ERR! Exit status 1

@apmmachine
Copy link
Contributor

apmmachine commented May 16, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T20:13:19.549+0000

  • Duration: 39 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 255793
Skipped 0
Total 255793

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented May 16, 2022

run module tests for mysql2

@trentm
Copy link
Member Author

trentm commented May 16, 2022

The TAV tests passed: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2696/2/pipeline

@trentm trentm merged commit 5b6b8a9 into main May 16, 2022
@trentm trentm deleted the trentm/fix-tav-test-slow-npm6-install branch May 16, 2022 20:55
astorm pushed a commit that referenced this pull request May 19, 2022
@trentm
test: skip mysql2@2.2.3 in TAV tests to workaround npm v6 install iss…
0b15274 
…ue with github deps (#2696)

mysql2@2.2.3 (and only that version) has a github dep:
    "@types/mysql": "types/mysql",
Attempting to install that version with npm v6 (the npm in node v10, v12, and
v14) hits npm/cli#4896 which results in an
install so slow that is hits the default 2 minute 'npm install' timeout
in the `tav` tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorm astorm astorm approved these changes

Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trentm @apmmachine @astorm