Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rudimentary auto instrumentation integration tests #120

Merged
merged 27 commits into from
Jul 10, 2024
Merged

Rudimentary auto instrumentation integration tests #120

merged 27 commits into from
Jul 10, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jul 8, 2024

  • Add example instrumentation project and dockerfile
  • Very rudimentary plugin tests
  • rename to .IntegrationTests
  • dotnet format
  • add integrate target

Mpdreamz added 27 commits July 8, 2024 16:54
@Mpdreamz
Add example instrumentation project and dockerfile
42403b1
@Mpdreamz
Very rudimentary plugin tests
aabe95a
@Mpdreamz
rename to .IntegrationTests
ef60798
@Mpdreamz
dotnet format
e5059bf
@Mpdreamz
add integrate target
f49d4c8
@Mpdreamz
fix build usage missing pattern match
e9bf2d0
@Mpdreamz
fix license header
919d28f
@Mpdreamz
move to TARGETARCH
fefc562
@Mpdreamz
put debug print of archs at the top
db9a558
@Mpdreamz
remove copy of netfx dll
64fefc8
@Mpdreamz
Release => release
9f49037
@Mpdreamz
hack to enforce copy
dd5c8e5
@Mpdreamz
more debugging why we can copy files from build_plugin on GithubActions
0148e2a
@Mpdreamz
quote files
b7ebadb
@Mpdreamz
attempt #5 to get a copy from build_plugin to work on Github Action
11e4f39
@Mpdreamz
attempt #6 to get a copy from build_plugin to work on Github Action
a565698
@Mpdreamz
attempt #7 to get a copy from build_plugin to work on Github Action
fd717e3
@Mpdreamz
attempt 8 to get a copy from build_plugin to work on Github Action
d979545
@Mpdreamz
attempt 9 to get a copy from build_plugin to work on Github Action
fe054c5
@Mpdreamz
attempt 10 to get a copy from build_plugin to work on Github Action
18cfbc7
@Mpdreamz
manually add TARGETARCH to TestContainer build
8e8d416
@Mpdreamz
ensure arg is available in last step in build
df6a350
@Mpdreamz
debug message
f1f8e59
@Mpdreamz
remove debug message
b779753
@Mpdreamz
remove debug message
da883be
@Mpdreamz
skip on windows and dockerfile cleanup
c3578a8
@Mpdreamz
share OTEL_VERSION properly over stages
2a1bd44
@Mpdreamz Mpdreamz requested a review from stevejgordon July 9, 2024 12:45
stevejgordon
stevejgordon approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible cleanup but otherwise LGTM as is.

examples/Example.AutoInstrumentation/Dockerfile Show resolved Hide resolved
@Mpdreamz Mpdreamz merged commit ae1c927 into main Jul 10, 2024
5 checks passed
@stevejgordon stevejgordon deleted the feature/auto-instrumentation-tests branch November 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @stevejgordon