feat(instr-openai): support openai@5 #521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for instrumenting openai@5, including prereleases (because that's all there are right now).
checklist
HTTP mocking troubles
openai@5 switched to Node.js native
fetch()for HTTP requests. That means Node.js' internalundiciis being used rather than thehttp/httpsmodules. I believe that means nock for HTTP mocking no longer works.I don't have an idea at a solution yet. Undici does have a https://undici.nodejs.org/#/docs/api/MockClient.md but I haven't played with that yet.