Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lab color #142

Merged
merged 10 commits into from
Nov 26, 2023
Merged

Add support for lab color #142

merged 10 commits into from
Nov 26, 2023

Conversation

elchininet
Copy link
Owner

@elchininet elchininet commented Nov 26, 2023

This is a major update of the library, it adds support for CIE L*a*b color conversion. With this change the properties of the color objects have been changed to capital letters because of the next reasons:

  • For consistency. For example, if the property to get the red channel is R and the property to get the rgb representation of the color is RGB it didn‘t make sense to work with objects with lowercase properties. It is more consistent if these properties are in capital letters too. E.g. { R: 255, G: 255, B: 0, A: 0.5 }
  • To make it possible to have CIE L*a*b colors with alpha. E.g. {L: 100, a: 50, b: 10, A: 0.5}

Closes: #140

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@uncenter
Copy link
Contributor

Looks good to me!

README.md Outdated Show resolved Hide resolved
elchininet and others added 2 commits November 26, 2023 23:37
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@elchininet elchininet merged commit 0eee83f into master Nov 26, 2023
1 check passed
@elchininet elchininet deleted the add_support_for_Lab_color branch November 26, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to L*a*b* format
2 participants