-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for lab color #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
reviewed
Nov 26, 2023
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Looks good to me! |
uncenter
reviewed
Nov 26, 2023
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update of the library, it adds support for CIE L*a*b color conversion. With this change the properties of the color objects have been changed to capital letters because of the next reasons:
R
and the property to get thergb
representation of the color isRGB
it didn‘t make sense to work with objects with lowercase properties. It is more consistent if these properties are in capital letters too. E.g.{ R: 255, G: 255, B: 0, A: 0.5 }
CIE L*a*b
colors with alpha. E.g.{L: 100, a: 50, b: 10, A: 0.5}
Closes: #140