Skip to content

Commit

Permalink
Remove start page and its build dependencies (microsoft#16834)
Browse files Browse the repository at this point in the history
* First deletion pass
* Remove commands & settings
* Remove cusotm webview implementation
* Remove build steps
* Re-add mocks
* Update Pylance prompt
* Remove "jupyter not installed" notification
* Add news file
* Remove a plugin that seems to be unused
* Remove gulpfile ref
* Remove telemetry constant
* Remove unused telemetry event
* Remove tsx checks
* Undo some formatting changes
* Remove react-related deps
* Re-add ESLint plugins
* Remove comment
* Remove out/server from gulpfile
* Remove ABExperiments type
  • Loading branch information
kimadeline authored Aug 10, 2021
1 parent eafbd9e commit a6dc358
Show file tree
Hide file tree
Showing 91 changed files with 661 additions and 8,740 deletions.
23 changes: 0 additions & 23 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,6 @@ src/client/common/nuget/types.ts
src/client/common/nuget/nugetService.ts
src/client/common/cancellation.ts
src/client/common/interpreterPathService.ts
src/client/common/startPage/startPageMessageListener.ts
src/client/common/application/applicationShell.ts
src/client/common/application/languageService.ts
src/client/common/application/notebook.ts
Expand Down Expand Up @@ -511,25 +510,3 @@ src/client/workspaceSymbols/generator.ts
src/client/workspaceSymbols/parser.ts
src/client/workspaceSymbols/provider.ts

src/client/common/startPage/codeCssGenerator.ts
src/client/common/startPage/themeFinder.ts
src/client/common/startPage/webviewHost.ts
src/client/common/startPage/webviewPanelHost.ts
src/startPage-ui/common/main.ts
src/startPage-ui/react-common/image.tsx
src/startPage-ui/react-common/locReactSide.ts
src/startPage-ui/react-common/logger.ts
src/startPage-ui/react-common/postOffice.ts
src/startPage-ui/startPage/index.tsx
src/test/startPage/mockCommandManager.ts
src/test/startPage/mockDocument.ts
src/test/startPage/mockDocumentManager.ts
src/test/startPage/mockExtensions.ts
src/test/startPage/mockTextEditor.ts
src/test/startPage/mockWorkspaceConfig.ts
src/test/startPage/mockWorkspaceFolder.ts
src/test/startPage/mountedWebView.ts
src/test/startPage/mountedWebViewFactory.ts
src/test/startPage/reactHelpers.ts
src/test/startPage/webBrowserPanel.ts
src/test/startPage/webBrowserPanelProvider.ts
7 changes: 0 additions & 7 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"selector": "ForInStatement",
"message": "for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array."
},

{
"selector": "LabeledStatement",
"message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
Expand All @@ -97,12 +96,6 @@
}
],
"operator-assignment": "off",
"react/jsx-filename-extension": [
1,
{
"extensions": [".tsx"]
}
],
"strict": "off"
}
}
2 changes: 1 addition & 1 deletion .sonarcloud.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
sonar.sources=src/client,src/startPage-ui
sonar.sources=src/client
sonar.tests=src/test
sonar.cfamily.build-wrapper-output.bypass=true
sonar.cpd.exclusions=src/client/activation/**/*.ts
15 changes: 3 additions & 12 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,14 @@
"type": "npm",
"script": "compile",
"isBackground": true,
"problemMatcher": ["$tsc-watch"],
"problemMatcher": [
"$tsc-watch"
],
"group": {
"kind": "build",
"isDefault": true
}
},
{
"label": "Compile Web Views",
"type": "npm",
"script": "compile-webviews-watch",
"isBackground": true,
"group": {
"kind": "build",
"isDefault": true
},
"problemMatcher": ["$tsc-watch"]
},
{
"label": "Run Unit Tests",
"type": "npm",
Expand Down
1 change: 0 additions & 1 deletion .vscodeignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
**/*.map
**/*.analyzer.html
!out/startPage-ui/viewers/
*.vsix
.editorconfig
.env
Expand Down
72 changes: 0 additions & 72 deletions build/webpack/plugins/less-plugin-base64.js

This file was deleted.

8 changes: 0 additions & 8 deletions build/webpack/webpack.startPage-ui-viewers.config.js

This file was deleted.

Loading

0 comments on commit a6dc358

Please sign in to comment.