Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support online web calendar #805

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Support online web calendar #805

merged 3 commits into from
Mar 25, 2024

Conversation

minhdanh
Copy link
Contributor

@minhdanh minhdanh commented Jan 28, 2024

This fixes #745 and #590

image

@xvelasqu
Copy link

It would be nice to get this merged. Thanks @minhdanh !!

@minhdanh
Copy link
Contributor Author

@xvelasqu Thanks. I'm still waiting for this PR to be reviewed 😅

@ryonakano ryonakano requested a review from a team March 21, 2024 03:03
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for this PR it would actually be quite useful for me too! :)

It also works really well, I just left some comments about things I noticed.

core/Utils.vala Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Outdated Show resolved Hide resolved
plugins/Web/WebBackend.vala Show resolved Hide resolved
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing I noticed is that deleting added calendars doesn't work. But since it doesn't work for all types of calendars I guess it isn't a blocker here :)

@leolost2605 leolost2605 merged commit 03fc11e into elementary:master Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add a function to subscribe a online ICS calender stream
4 participants