Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed shorthand tags and replaced them with <?php as per the guidelines #1790

Merged
merged 3 commits into from
Aug 18, 2017
Merged

Removed shorthand tags and replaced them with <?php as per the guidelines #1790

merged 3 commits into from
Aug 18, 2017

Conversation

javielico
Copy link
Contributor

As per issue #1778

Changes Summary

  • Changed the shorthand tags on brand.php for the long ones

@javielico javielico mentioned this pull request Aug 18, 2017
Closed
javielico
javielico commented Aug 18, 2017
View reviewed changes
Copy link
Contributor Author

@javielico javielico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes

btkostner
btkostner suggested changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes to root. Because those are images they shouldn't be prefixed with the language.

Everything else looks good.

@javielico
Copy link
Contributor Author

javielico commented Aug 18, 2017 •
edited
Loading

Hi @btkostner do you mean that the line should be:
<img src="<?php echo $sitewide['root'];?>images/brand/logotype.png" alt="elementary Logotype"/>

@btkostner
Copy link
Contributor

Yep

@javielico
Copy link
Contributor Author

That's now done for you 👍

@btkostner
Copy link
Contributor

Awesome. Thank you for the PR!

@btkostner btkostner merged commit bbaea05 into elementary:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btkostner btkostner btkostner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javielico @btkostner