Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'any' with correct types in typescript code #3279

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

caponetto
Copy link
Contributor

@caponetto caponetto commented Jan 15, 2025

What changes were proposed in this pull request?

Cherry-picked from ODH Elyra

While migrating the extensions to JupyterLab v4, we faced issues related to type incompatibility after library upgrades. Many of these issues were identified only at runtime due to the extensive usage of any throughout the code instead of the correct types. So, this PR reviews the usage of any and makes appropriate changes to avoid it as much as possible. Also, the build now throws an error if any is used without a reason. Given the structure of the code that has been built on top of any, the changes on this PR are not perfect, but, hopefully, they will provide more protection to the code on future fixes, upgrades, and new features.

How was this pull request tested?

Through CI runs and manual tests.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

* Replace 'any' with correct types in typescript code

* Replace 'any' with correct types in typescript code (complex cases)

* Fix tags not being shown

* Add missing packageManager prop to install.json file

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
@caponetto caponetto requested a review from lresende January 15, 2025 10:47
@lresende lresende merged commit 381e711 into elyra-ai:main Jan 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants