Skip to content

Commit

Permalink
Reset flag default value (#471)
Browse files Browse the repository at this point in the history
Reset the default of `allow_recommending_already_recommended` back to
`False`, which was forgotten in #423.
  • Loading branch information
AdrianSosic authored Jan 29, 2025
2 parents ac805e8 + b0c3e52 commit fb6e7d8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.12.1] - 2025-01-29
### Changed
- Default of `allow_recommending_already_recommended` is changed back to `False`
to avoid exploitation cycles ([#468](https://github.com/emdgroup/baybe/issues/468))

## [0.12.0] - 2025-01-28
### Breaking Changes
- Lookup callables for simulation are now expected to accept/return dataframes with
Expand Down
2 changes: 1 addition & 1 deletion baybe/campaign.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class Campaign(SerialMixin):

allow_recommending_already_recommended: bool | UnspecifiedType = field(
default=Factory(
_make_allow_flag_default_factory(default=True), takes_self=True
_make_allow_flag_default_factory(default=False), takes_self=True
),
validator=_validate_allow_flag,
kw_only=True,
Expand Down

0 comments on commit fb6e7d8

Please sign in to comment.