fixed broken percentage_design & extended testing #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing and reopening to trigger a new build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The percentage definition in BatteryChecker uses the wh_remaining & wh_total methods instead of the percentage method. While battery.percentage takes into account the design=True/False flag, battery.wh_total does not. This lead to percentage and percentage_design being reported as exactly the same number (with percentage_design being incorrect). I have edited the two wh_total functions to recognize the design flag and return the proper value when it is true, and extended the testing to percentage & percentage_design.
Note that test_battery_issue729 will fail (reporting FULL rather than DIS) until #730 is merged.